https://bugzilla.redhat.com/show_bug.cgi?id=1405708

Igor Gnatenko <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review+



--- Comment #2 from Igor Gnatenko <[email protected]> ---
* Move desktop-file-validate and appstream-util to %check section
* %{_datadir}/icons/hicolor/128x128/apps/%{name}.png ->
%{_datadir}/icons/hicolor/*/apps/%{name}.png (who knows if upstream will add
more icons
* there is also CC0 and QPL licenses in -data subpackage
* Main package also contains MIT license (due to
lugaru-1.1/Source/Thirdparty/optionparser.h)

* Also I think we should add Requires: hicolor-icon-theme
     Note: Directories without known owners: /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/128x128/apps,
     /usr/share/icons/hicolor/128x128


Otherwise looks good (this can be fixed during import). APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to