https://bugzilla.redhat.com/show_bug.cgi?id=1392089
Athos Ribeiro <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(athoscribeiro@gma | |il.com) | --- Comment #7 from Athos Ribeiro <[email protected]> --- Hi Peter, I am sorry for the delay here, I have been travelling in the past few weeks and probably missed the emails on this bug. Please, see bug 1401337 and [1] python-zeroconf was reviewed and approved during our review here, but the maintainer only included a python3-zeroconf package and we do need a python2-zeroconf for bug 1392090 We can either check if the maintainer is willing to add python2-zeroconf to the python-zeroconf package or rename this package to python2-zeroconf, remove the python3-zeroconf subpackage and proceed with the review. I believe the former would be preferred, and if you agree, I would even contact the maintainer and send him a patch to include python2-zeroconf. Else, here is the review of the package: I only found 2 issues here: 1 - the python3-zeroconf owns /usr/lib/python3.5/site-packages/__pycache__ which belongs to system-python-libs. This issue appears in a few python3 packages when we use wildcards like %{python3_sitelib}/* Since the python3 subpackage would be removed, this should be ignored. 2 - spec file line 2 reads: %define with_tests 0 Guidelines sugest we use %global instead, as you can see in [2]. Note that this is not a must. Other than that, the python2 package would be ready, if that's how you'd like to proceed. [1] https://admin.fedoraproject.org/pkgdb/package/rpms/python-zeroconf/ [2] https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
