https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #4 from Neal Gompa <[email protected]> ---
A couple of questions here:

> Source0:        
> https://github.com/%{github_owner}/%{github_name}/archive/%{github_commit}/%{github_name}-%{version}.tar.gz

Why are you using the GitHub commit to do this? It forces you to declare a
folder name in %autosetup later on. GitHub does provide
https://github.com/Runscope/httpbin/archive/v0.5.0.tar.gz as an option.

You can use it as a Source0 like so:
https://github.com/%{github_owner}/%{github_name}/archive/v%{version}/%{github_name}-%{version}.tar.gz

> LANG=en_US.UTF-8 %py3_build

Why the LANG? Could you put a comment explaining why that was necessary?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to