https://bugzilla.redhat.com/show_bug.cgi?id=1398949



--- Comment #30 from MartinKG <[email protected]> ---
(In reply to Jeremy Newton from comment #29)
> Looks good, but the one issue remains. You need to set DCMAKE_SKIP_RPATH to
> ON. You need this ON to skip the build step that adds rpath to the binaries.
> The use of chrpath can be avoided by turning this on.
> 
> Please fix this prior to importing the package.
> 
> Approved.

done
Many thanks for the review.

New bear Package:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/bear.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/bear-0.7.0-0.7gitac6be8b.fc25.src.rpm

%changelog
* Fri Dec 23 2016 Martin Gansser <[email protected]> -
0.7.0-0.7gitac6be8b
- change to -DCMAKE_SKIP_RPATH:BOOL=ON
- obsolete chrpath command
- convert docbook2man filename taken from .sgml file to lowercase

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to