https://bugzilla.redhat.com/show_bug.cgi?id=1397261
--- Comment #8 from Neal Gompa <ngomp...@gmail.com> --- Initial review notes: - libmad is now in Fedora, so that module can be enabled - Please split AppStream metainfo file out into a separate source file and install it that way - Also, please check on whether metainfo file is complete. Meaning, does it have enough information for GNOME Software or Plasma Discover to use the information to be able to select the codecs when queried by applications? I suspect not. See: https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Codec.html > make %{?_smp_mflags} Please change to "%make_build" > make install DESTDIR=$RPM_BUILD_ROOT Please change to "%make_install" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
