https://bugzilla.redhat.com/show_bug.cgi?id=1404305
Randy Barlow <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) --- Comment #3 from Randy Barlow <[email protected]> --- It installs now! I have one thing you need to fix before I can approve, and a few suggestions that are at your option: Must fix ======== * The Python package must be named python3-bcc instead of bcc-python3, as per the Python packaging guidelines: https://fedoraproject.org/wiki/Packaging:Python#Provides Optional suggestions ==================== * fedora-review doesn't think you need to BuildRequire gcc or gcc-c++. * It would be good to include a link to an upstream pull request, or a comment explaining the purpose of the patch and why it isn't submitted upstream in the spec file. * The Python package should Require: bcc with the %{?_isa} macro. * There does appear to be a test suite upstream. It would be good to add a %check section that runs it. * Consider making bcc-doc and gcc-tools noarch packages. python3-gcc should be a noarch package as well since it installs to /usr/lib/. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
