https://bugzilla.redhat.com/show_bug.cgi?id=1344276
--- Comment #19 from Ken Dreyer <[email protected]> --- %global gdeploytemp /usr/share/ansible/gdeploy - Instead of "/usr/share/ansible/gdeploy", why not use "/usr/share/gdeploy"? Putting the files under another package's namespace (ansible) could lead to problems in the future. - Please use the %{_datadir} macro here instead of /usr/share. %global gdeploydoc /usr/share/doc/gdeploy - Please use the %{_pkgdocdir} macro and eliminate %{gdeploydoc}. install -m 755 extras/usecases/replace-node/gluster-replace-node \ %{buildroot}/usr/bin - Do you need to make %{buildroot}/usr/bin here?, or does the earlier "setup.py install" command already create that directory for you? /usr/bin/gluster-replace-node - Please use the %{_bindir} macro here %global _rpmfilename noarch/%{name}-%{version}-%{release}%{?dist}.rpm I don't think this line is needed. %description - "and lot more" -> "and more" (grammar fix) %autosetup -n %{name}-%{version} - %{name}-%{version} is the default already, no need to specify it here. The "cp" and "install" statements do not preserve timestamps. Please use the "-p" options. Please review some other packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
