https://bugzilla.redhat.com/show_bug.cgi?id=1411036
--- Comment #2 from Filip Szymański <[email protected]> --- Hi Mike, 1) Spec file URL must be raw: https://raw.githubusercontent.com/xenithorb/fedora-specs/master/python-ECPy/python-ECPy.spec 2) The %{?dist} tag can not be 0: Release: 1%{?dist} 3) According to the SourceURL packagin guidelines Source0 should look like this: Source0: https://github.com/ubinity/%{srcname}/archive/v%{version}/%{srcname}-%{version}.tar.gz See: https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags 4) The `sum` global is unnecessary, use %{summary} macro: Summary: Pure Python Elliptic Curve Library ... %package -n python2-%{srcname} Summary: %{summary} Requires: python2-future %{?python_provide:%python_provide python2-%{srcname}} ... 5) The future module is only required by Python 2 (see setup.py file). 6) Create a documentation subpackage (example below): BuildRequires: python3-sphinx ... %package doc Summary: Documentation for python-%{srcname} %description doc This package contains the documentation for python-%{srcname}. ... %build %py2_build %py3_build %make_build -C doc singlehtml rm -f doc/build/singlehtml/{.buildinfo,.nojekyll} ... %files doc %license LICENSE %doc doc/build/singlehtml/* 7) If there are no tests remove the %check section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
