https://bugzilla.redhat.com/show_bug.cgi?id=1327979
--- Comment #9 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- Review update: (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > Links in /bin/ should be updated similarly to python-jupyter-client. Links are still reversed. It should be like this: mv %{buildroot}/%{_bindir}/jupyter-nbextension %{buildroot}/%{_bindir}/jupyter-nbextension-%{python3_version} ln -s jupyter-nbextension-%{python3_version} %{buildroot}/%{_bindir}/jupyter-nbextension-%{python3_pkgversion} mv %{buildroot}/%{_bindir}/jupyter-serverextension %{buildroot}/%{_bindir}/jupyter-serverextension-%{python3_version} ln -s jupyter-serverextension-%{python3_version} %{buildroot}/%{_bindir}/jupyter-serverextension-%{python3_pkgversion} mv %{buildroot}/%{_bindir}/jupyter-notebook %{buildroot}/%{_bindir}/jupyter-notebook-%{python3_version} ln -s jupyter-notebook-%{python3_version} %{buildroot}/%{_bindir}/jupyter-notebook-%{python3_pkgversion} and similarly for the python2 version. > %license. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING.md is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > Suggestion to use "%global _docdir_fmt %{name}". > > %description should be word wrapped to 80 columns. > And since the description is longer than two sentences, it's nice to define > a %_description and then use '%description [subpackage ] %_description' to > avoid repeating the text. Still valid. Can you post an updated spec file? It would be great to get this wrapped up some time before F26, leaving enough time for testing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
