https://bugzilla.redhat.com/show_bug.cgi?id=1412801
--- Comment #1 from Igor Gnatenko <[email protected]> --- * Any reason to make this python3 stuff conditional? And there is anyway problem with that 34, you should use %python3_pkgversion, but most probably you just don't want to build python3 subpackage under EPEL. Would be better if you will use: %if 0%{?rhel} && 0%{?rhel} <= 7 %bcond_with python3 %else %bcond_without python3 %endif * Move BuildRequires under subpackages (it's more readable) * You can reuse %{summary} from subpackages * Any reason not to take archive from github? * Missing %python_provide macro * GitHub url should be https://, not http:// * %setup -q -n python-networkmanager-%{version}, it's equivalent to %setup -q -n %{name}-%{version} were -n %{name}-%{version} can be omitted. Though I would just replace it with %autosetup * Actually pythonX-setuptools is not needed at all since package doesn't use setuptools for building * I didn't check, but I guess missing Requires: pythonX-dbus * I would recommend to package examples as %doc (kinda useful stuff) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
