https://bugzilla.redhat.com/show_bug.cgi?id=1414216
--- Comment #3 from Remi Collet <[email protected]> --- (In reply to Randy Barlow from comment #2) > I ended up adding a require_once onto the existing upstream autoloader - > will that work? You need to check in mock to ensure everything is OK. php-gettext-languages will install in /usr/share/php/Gettext/Languages with its autoloader. php-gettext-gettext will install in /usr/share/php/Gettext with its autoloader. As gettext autoloader manage the "Gettext" namespace, il will also manage the Languages sub-namespace, as both are installed in the same directory. But this WONT work during the build. (languages in /usr..., gettext in %{buildroot}/usr...) So you really have to include/require Languages autoloader from the Gettext one. > As for the tests, this package has four optional dependencies, and two of > the tests were failing without them. Since the dependencies are explicitly > listed as optional in the composer.json, I opted to skip running them for > now. Is that OK by you? Ok for missing dep. But twig is available in the repo, so worth to be used (BuildRequires + Suggests) Which mean the GetText autoloader will need to also load these. Ex (using fedora autoloader) \Fedora\Autoloader\Dependencies::required(array( '/usr/share/php/Gettext/Languages/autoloader.php' )); \Fedora\Autoloader\Dependencies::optional(array( '/usr/share/php/Twig/Extensions/autoload.php', '/usr/share/php/Twig/autoload.php', )); (which also means the upstream autoloader doesn't really suite our needs) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
