https://bugzilla.redhat.com/show_bug.cgi?id=1416492
Petr Pisar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <[email protected]> --- URL and Source0 addresses are usable. Source archive (SHA-256: c7edcc52a397bd165cdb71a409fae140825275d913d0c37d2837cbf78c63396a) is original. Summary is good. Description is good. License verified from LICENSE and lib/Task/Kensho/XML.pm. Ok. No XS code, noarch BuildArch is Ok. Module::Build::Tiny not needed. Ok. TODO: Do not build-require modules (RDF::Trine, XML::Generator::PerlData, XML::LibXML, XML::LibXSLT, XML::SAX, XML::SAX::Writer) that are not needed at build or check time. The tests pass even without them. CPAN::Meta and CPAN::Meta::Prereqs not helpful. Ok. $ rpmlint perl-Task-Kensho-XML.spec ../SRPMS/perl-Task-Kensho-XML-0.39-1.fc26.src.rpm ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm perl-Task-Kensho-XML.src: W: spelling-error %description -l en_US amongst -> among st, among-st, among perl-Task-Kensho-XML.noarch: W: spelling-error %description -l en_US amongst -> among st, among-st, among 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Jan 26 10:22 /usr/share/doc/perl-Task-Kensho-XML -rw-r--r-- 1 root root 6777 May 14 2016 /usr/share/doc/perl-Task-Kensho-XML/Changes -rw-r--r-- 1 root root 1602 May 14 2016 /usr/share/doc/perl-Task-Kensho-XML/README drwxr-xr-x 2 root root 0 Jan 26 10:22 /usr/share/licenses/perl-Task-Kensho-XML -rw-r--r-- 1 root root 18352 May 14 2016 /usr/share/licenses/perl-Task-Kensho-XML/LICENSE -rw-r--r-- 1 root root 3054 Jan 26 10:22 /usr/share/man/man3/Task::Kensho::XML.3pm.gz drwxr-xr-x 2 root root 0 Jan 26 10:22 /usr/share/perl5/vendor_perl/Task drwxr-xr-x 2 root root 0 Jan 26 10:22 /usr/share/perl5/vendor_perl/Task/Kensho -rw-r--r-- 1 root root 4281 May 14 2016 /usr/share/perl5/vendor_perl/Task/Kensho/XML.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(RDF::Trine) 1 perl(strict) 1 perl(warnings) 1 perl(XML::Generator::PerlData) 1 perl(XML::LibXML) 1 perl(XML::LibXSLT) 1 perl(XML::SAX) 1 perl(XML::SAX::Writer) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Task::Kensho::XML) = 0.39 1 perl-Task-Kensho-XML = 0.39-1.fc26 Binary provides are Ok. $ resolvedeps f26-build ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17420376). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please fix the `TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
