https://bugzilla.redhat.com/show_bug.cgi?id=1417495
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |[email protected] See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=209224 Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- This one also hangs in test-lock :( Can you move %{?systemd_requires} next to the other "Requires:"? It's confusing to have it with "BuildRequires:". Grammaro: "This plugin authorize prelude-manager to log into XML files." → "This plugin allows prelude-manager to log into XML files."? Really, logging into XML files, bleh ;) I'd also drop the rest of the description in db-plugin, xml-plugin, devel, that just repeats the general description of prelude-manager. In the service file: > Description=Run prelude-manager This will result in messages like "Starting Run prelude-manager" and "Stopping Run prelude-manager". Description should be something that fits in that template, e.g. Description=Prelude bus communicator. OK, the daemon listens of 127.0.0.1 by default, seems reasonable. + package name is OK + license is acceptable (GPLv2+) + license is specified correctly + builds and installs OK + scriptlets are sane + R/BR/P look correct + fedora-review detects no issues + %check is present, and tests pass, except for one test Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
