https://bugzilla.redhat.com/show_bug.cgi?id=1418208
--- Comment #3 from Damian Wrobel <[email protected]> --- (In reply to Andrew Bauer from comment #1) > Package builds in rawhide, package owns the files & folders it creates w/ > proper permissions. > > https://koji.fedoraproject.org/koji/taskinfo?taskID=17545923 > > > - I like how you handled the license, but I'm wondering if we ought to > instead reference the actual Perl license text, rather than gpl 3, since > that is what is referred to on the class:std::fast cpan site. > > See "The Perl 5 License (Artistic 1 & GPL 1)" -> > http://dev.perl.org/licenses/ > > Doing that would then bring the license text in alignment with what is > stated in the License: field in the rpm specfile. > > This is just my opinion and I am not a lawyer, so feel free to respond as > you see fit. I found a similar case in a bug 1394267, comment 2 and in the end the package didn't include any file in %license tag, which IMHO is not in line with https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text, so I added a text from http://dev.perl.org/licenses/ as you suggested. I've also sent an e-mail to bug-Class-Std-Fast [at] rt.cpan.org asking authors to include license's text into distribution. > > - perl-generators is listed twice as a buildrequires Removed. > - rpmlint spotted trivial issues with the wording in the description as > shown below. I took the original description from https://metacpan.org/pod/Class::Std::Fast#DESCRIPTION > > $ rpmlint perl-Class-Std-Fast-0.0.8-1.fc25.noarch.rpm > perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US ident -> > dent, indent, i dent > perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US > scalarifiyng -> scarification > perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US > scalarify -> scarify, clarify > 1 packages and 0 specfiles checked; 0 errors, 3 warnings. > > $ rpmlint perl-Class-Std-Fast-0.0.8-1.fc25.src.rpm > perl-Class-Std-Fast.src: W: spelling-error %description -l en_US ident -> > dent, indent, i dent > perl-Class-Std-Fast.src: W: spelling-error %description -l en_US > scalarifiyng -> scarification > perl-Class-Std-Fast.src: W: spelling-error %description -l en_US scalarify > -> scarify, clarify > 1 packages and 0 specfiles checked; 0 errors, 3 warnings. > > In my opinion, this is what I would do: > "You can get the object's identity via scalar-ifying your object. Getting > the objects identity is still possible via the ident method" Thank you for providing the correction - applied. > > rpmlint will still complain about that last "ident" but in that case the > actual name of the method is being referred to. Updated spec & srpm: Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/perl-Class-Std-Fast.spec SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/perl-Class-Std-Fast-0.0.8-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
