https://bugzilla.redhat.com/show_bug.cgi?id=1418940

Remi Collet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Remi Collet <[email protected]> ---
Hi,

Quick notes:

According to git history, this is not a "pre" release, but a post tag release,
So a better version is 1.0.0-1.20160322git56f1e3b

From phpcompatinfo report, missing dep: php-pcre

I totally agree using namespace is a must, btw, worth to be submitted upstream,
as a PR.

Perhaps a minimal %check for autoloader could be useful

BuildRequires: php-cli
%check
php -r '
require "%{buildroot}%{php_home}/%{ns_vendor}/%{ns_project}/autoload.php";
exit (class_exists("CamSpiers\\PorterStemmer\\Porter") ? 0 : 1);
'

Must own /usr/share/php/CamSpiers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to