https://bugzilla.redhat.com/show_bug.cgi?id=1415331

Raphael Groner <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Raphael Groner <[email protected]> ---
Taken. Thanks for looking into bug #1385856. :)

Some general hints before I'll run official fedora-review:

- Please try to send your patches to upstream: manpage, install and start
script.

https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

- Why does upstream not provide a build/install environment? A proper build
script can avoid confusion about right build flags. Maybe we can suggest
setuptools.
 https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling

- The sitelib folder should be in a separate subpackage python3-enjarify with
support for the virtual provides of python-enjarify.
 https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro

- Manpage is special documentation without the need to be marked with %doc.
 https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages

- Please use also install -p for the manpage to preserve original timestamp.
 https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to