https://bugzilla.redhat.com/show_bug.cgi?id=1419226
--- Comment #4 from Thomas Andrejak <[email protected]> --- Hello, Here are the new files : SPEC : https://fedorapeople.org/~totol/prelude-correlator.spec SRPM : https://fedorapeople.org/~totol/prelude-correlator-3.1.0-1.fc26.src.rpm (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > s/SystemD/systemd/ > > + package name is OK > + license is acceptable (GPLv2) > - license is specified correctly: > not, it's GPLv2+, see the headers in the files Indeed, Done > > Why /etc/prelude-correlator/rules? That python code does not look like > something that is configurable, wouldn't it be better to put it somewhere in > /usr/? This is python files but this is really configuration files. This is where the user describes it's correlation rules. The user can add rules, delete rules, modify rules. > > Does the binary fork anything? If there's just one process, you can do away > with the pid file, which would obviate the need for a directory in /run and > simplify things. Yes, Done > > Could this daemon run as a normal user? What kind of privileges does is > require? Prelude-Correlator seems to have this functionnality but it dit it in the wrong way. I prefere not to activate it and wait for upstream. > > Hm, why do the python subpackage require prelude-correlator.rpm? > prelude-correlator includes a service file which will not work without > python3-p-c, so it seems prelude-correlator.rpm should require > python3-prelude-correlator. I'm pretty sure that 'dnf install > prelude-correlator' should yield a working setup. You are right, Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
