https://bugzilla.redhat.com/show_bug.cgi?id=1421603
Tomas Tomecek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Tomas Tomecek <[email protected]> --- Well, since we don't have any `fedora-review` nor `rpmlint`, I'll just inline-comment: > io.k8s.display-name="Fedora alternative to Developer Toolset Toolchain" I would name it as "Fedora variant of software collection Devel..." Not sure about capitals. > ADD contrib/bin/usage /usr/local/bin/usage Why don't you add it to /opt/app-root? (nitpick) I would also prefer COPY (since ADD may have side effects). > https://hhorak.fedorapeople.org/toolchain-docker/contrib/etc/scl_enable This seems redundant. I would also like to see some documentation with better examples: how would I use the container to compile my code? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
