https://bugzilla.redhat.com/show_bug.cgi?id=1422689

Neal Gompa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Neal Gompa <[email protected]> ---
Review notes:

+ Package is named correctly
+ Package has license noted correctly and license file is installed in all
subpackages
+ Subpackages are set up according to Python packaging guidelines
+ No issues from rpmlint or fedora-review
- Empty %check section (at least you know, so not dinging you about it!)
! Unnecessary "rm -rf %{buildroot}" in %install (this isn't targeting EL5...)

It looks good to me. Just drop the unnecessary command in %install mentioned
above on import.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to