https://bugzilla.redhat.com/show_bug.cgi?id=1424825



--- Comment #5 from Björn "besser82" Esser <[email protected]> ---
(In reply to leigh scott from comment #2)
> You can remove  these as gnome-common requires them
> 
> BuildRequires:        autoconf
> BuildRequires:        automake
> BuildRequires:        gettext

Well, explicit BRs don't hurt.  ;)


> The package requires gschema scriptlets
> 
> %{_datadir}/glib-2.0/schemas/org.x.editor.*gschema.xml

Those are obsolete since F24+.  See: 
https://fedoraproject.org/wiki/Packaging:Scriptlets#GSettings_Schema


> You also have a directory ownership issue on
> 
> %{_datadir}/help
> 
> change it to 
> 
> %{_datadir}/help/*/%{name}/

Will fix that in short.


> Do we really need the debian bits?
> 
> %license AUTHORS COPYING debian/copyright
> %doc ChangeLog README debian/changelog

I package them, since the debian-changelog is usually more up2date…

***

Updated package:

Urls:

Spec URL:  https://pagure.io/besser82/package-review/raw/master/f/xviewer.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/xviewer-1.2.2-0.2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to