https://bugzilla.redhat.com/show_bug.cgi?id=1424721
Remi Collet <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Remi Collet <[email protected]> --- [!]: Package complies to the Packaging Guidelines From PHP Guildelines A PSR-4 [2] compliant library would put its PHP files in /usr/share/php/<Vendor Name> in a PSR-0 compliant tree. So should be /usr/share/php/ZipStream BTW, as "vendor" is missing, To avoid possible conflict with a too generic name, I'm fine with : /usr/share/php/maennchen/ZipStream /usr/share/php/maennchen/zipstream-php => Packager choice. [!]: Requires correct, justified where necessary. From composer.json "require": { "php": ">= 5.6", "ext-mbstring": "*" }, From phpcompatinfo report Requires PHP 5.3.0 (min), PHP 5.3.0 (all) This usually means upstream don't want to support EOL PHP version. => packager choise Do you need it in EPEL ? (build ok en epel-6 and epel-7) Tips: --bootstrap is not needed when the value in already defined in phpunit.xml --no-coverage avoid the "Error: No code coverage driver is available" (but requires phpunit > 4) No blocker, please just confirm PHP minimal version you want to support and file location. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
