https://bugzilla.redhat.com/show_bug.cgi?id=1424859
Piotr Popieluch <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review- --- Comment #1 from Piotr Popieluch <[email protected]> --- You must include the following in the %check section: %{__nodejs} -e 'require("./")' https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Build_testing_in_.25check other minor non-blocking comments (I guess the guidelines need some update); find_provides_and_requires Following line is not needed anymore (macros are in all Fedora and epel 6 & 7 now) %{?nodejs_find_provides_and_requires} nodejs_arches Fedora 19 is eol for long time and epel 6 & 7 have %{nodejs_arches} now. So following: %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif can be replaced with just: ExclusiveArch: %{nodejs_arches} noarch setup should be autosetup: %setup -q -n %{npm_name}-%{version} now: %autosetup -n %{npm_name}-%{version} You can remove the symlink part in the build section, this only generates useless warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
