https://bugzilla.redhat.com/show_bug.cgi?id=1424632
--- Comment #2 from Mohamed El Morabity <[email protected]> --- Hello Athos, many thanks for your review! (In reply to Athos Ribeiro from comment #1) > For python3 packages, it os not a good idea to have > %{python3_sitelib}/* > because you may end up owning directories that you should not own. > This is not the case for your package though, but I suggest you be more > specific there since the package may change. I just followed the spec template on the Python packaging guidelines page. But you're right anyway. I'll be careful for further updates, I promise ;) > Is there any reason for not running the test suite for the package (upstream > does provide one)? If not, it would be nice to run the test suite in %check. Tests are not available in the Pypi tarball. They're available on the Github upstream repo. Unfortunately, there's no release tag published on this repo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
