https://bugzilla.redhat.com/show_bug.cgi?id=1419547

Antonio Trande <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Blocks|                            |177841 (FE-NEEDSPONSOR)



--- Comment #2 from Antonio Trande <[email protected]> ---
You're not a packager yet. True?

Please, use direct links to the SPEC and SRPM files.

- GPL is  not a valid license.
http://fedoraproject.org/wiki/Licensing:Main
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines

- Probably, Make does not use default optimization flags.
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

- libdir is not set correctly.

- Use macros as much as possible
http://fedoraproject.org/wiki/Packaging:Guidelines#Macros
http://fedoraproject.org/wiki/Packaging:RPMMacros

- Empty %changelog?
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to