https://bugzilla.redhat.com/show_bug.cgi?id=1411053
--- Comment #3 from Tom Hughes <t...@compton.nu> ---
There's no need to require nodejs explicitly we an automatic require on
nodejs(engine) will be added anyway.
The execute bits should be removed from the files in the src directory.
We should probably remove the bundled qunit (tests/qunit) in %prep.
Obviously we can't run the tests until we have the qunit command line test
runner in but for the sake of documentation the command needed is:
qunit -c jschardet:src/init.js -t tests/jschardet.js
Note that the "module" line in tests/jschardet.js needs patching to
QUnit.module for use in nodejs as "module" at the top level is reserved to
node. Also all the "equals" calls produce deprecation warnings (and cause
failures) so need patch to "equal" instead. With all that I get 5 failures:
Module: jschardet Test: ISO-2022-CN
at Object.<anonymous>
(/home/thh/rpm/BUILD/package/tests/jschardet.js:111:5)
Actual value:
null
Expected value:
ISO-2022-CN
Module: jschardet Test: windows-1250 (Hungarian)
at Object.<anonymous>
(/home/thh/rpm/BUILD/package/tests/jschardet.js:129:5)
Actual value:
null
Expected value:
windows-1250
Module: jschardet Test: windows-1251 (Bulgarian)
at Object.<anonymous>
(/home/thh/rpm/BUILD/package/tests/jschardet.js:141:5)
Actual value:
ISO-8859-5
Expected value:
windows-1251
Module: jschardet Test: windows-1253 (Greek)
at Object.<anonymous>
(/home/thh/rpm/BUILD/package/tests/jschardet.js:154:5)
Actual value:
null
Expected value:
windows-1253
Module: jschardet Test: EUC-CN
at Object.<anonymous>
(/home/thh/rpm/BUILD/package/tests/jschardet.js:190:5)
Actual value:
null
Expected value:
EUC-CN
I haven't looked at them in any detail.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
