https://bugzilla.redhat.com/show_bug.cgi?id=1426844
--- Comment #2 from [email protected] --- (In reply to Nemanja Milosevic from comment #1) Hi and thanks for explaining all I will answer some of them and fix problems > Refrain from using constructs like this. Notepad++ is proprietary software if > I'm correct, and we shouldn't use their name without permission. Why not just > qt based advanced text editor. Notepad++ is GPL software, although I will change the name in description for you say > Source0: ... Fixed About the name, I changed as you write, sounds a bit strange but works > Source1: > https://github.com/notepadqq/CodeMirror/archive/5.18.2-nqq.tar.gz >Why is this needed, and what is this? If it's a needed library why not package >it separately? Its a submodule of notepadqq git, github doesnt download it when it downloads the .tar.gz . I didnt think of it as a library because is in it and its like a js file but a lot of it, as an addon. (And without it it doesnt builds) Corrected description About the patchs.. The launcher one I sent a better patch to upstream and its merged, but is not released yet (https://github.com/notepadqq/notepadqq/commit/13dec7d5e1008c0d14de56c739d45ec1477f4557 ) The rest, I put it in the prep section, I'm sorry but I dont understand how %patch works > Make doesn't respect RPM_OPT_FLAGS. Consider using %make_build. > Why aren't you using %make_install? I didnt use %make_build and %make_install because I read first time wiki in spanish (I'm Spanish) and it doesnt mention it.. I put %make_build, but it seems that make install doesnt change nothing > No need to remove RPM buildroot directory. I think is because same as above, removed line > You are mentioning node, which isn't listed as a requirement? Does it require > a newer version? It's because for 99% of users notepadqq doesnt need it, and I dont know if its a way to put "Optional" depends Uploaded changes: Spec URL: https://mirror.jkanetwork.com/Fedora/SOURCES/notepadqq.spec SRPM URL: https://mirror.jkanetwork.com/Fedora/SOURCES/notepadqq-1.0.1-5.fc25.src.rpm Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
