https://bugzilla.redhat.com/show_bug.cgi?id=1428035
Stephen Gallagher <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |m) --- Comment #16 from Stephen Gallagher <[email protected]> --- Spec: https://sgallagh.fedorapeople.org/packagereview/modular-release/fedora-modular-release.spec SRPM: https://sgallagh.fedorapeople.org/packagereview/modular-release/fedora-modular-release-26-0.6.fc26.src.rpm (In reply to Neal Gompa from comment #15) > @Stephen: > > * You've got the notice in place, so you're good there. > > * The spec should be called fedora-modular-release.spec > > * The package should be called fedora-modular-release > This was fixed in the spec included in the SRPM, but I posted the wrong spec link above. > * It should provide "system-modular-release" and > "system-modular-release(%{version})" in addition to standard ones (c.f. > edition release packages). > - This allows for rebranding and generic versions to replace it easily > enough. > Done > * The commented out "modular-repos(%{version})", if you decide to do that, > should be "fedora-modular-repos(%{version})". > Done > Also, I don't see an updated spec posted. The SRPM seems to be updated, so > maybe the spec is out of sync with the SRPM one. Sorry, I pasted the wrong one into the comment. Fixed here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
