https://bugzilla.redhat.com/show_bug.cgi?id=1426851

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Fabio Valentini <[email protected]> ---
koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18265648

I agree that this package looks good, just one minor remark: You could remove
the 3 empty %if-blocks at lines 52, 69 and 77 to clean the .spec file up a bit.

But since the .spec file is automatically generated (and the %if-blocks are
only empty because there are no additional dependencies), that is okay (and
this way it's easier to add dependencies, should the package grow new
dependencies in the future - which I doubt in this case, though).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to