https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #5 from Julien Enselme <[email protected]> ---
> No need to specify "BuildArch:      noarch" more than once.

Fixed.

> Those loops ("for file in leather/*.py; do...") are not necessary, sed takes 
> multiple arguments.

Indeed, fixed.

> I like minimalism, I'd also replace "pushd docs, popd" with a '-C docs' 
> argument to make...

I didn't know about this option. I fine with the pushd/popd so I'll let it as
is if you are fine with it.

> I also think the description could be a bit more down-to-earth.

Agreed. I took it from the readme. Improve with passage from the documentation
(http://leather.readthedocs.io/en/0.3.3/about.html).

Spec URL: http://dl.jujens.eu/SPECS/python-leather.spec
SRPM URL:
http://dl.jujens.eu/SRPMS/python-leather-0.3.3-2.gite85dd30.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to