https://bugzilla.redhat.com/show_bug.cgi?id=1433749



--- Comment #1 from Michael Schwendt <[email protected]> ---
Small as it may be, but there are still some relevant things in the guidelines:


> Name:          vrms-rpm
>
> %description
> vrms-rpm reports nonfree packages installed on the system.

Explaining in the package description what "vrms" means would be good. Is it
based one "Virtual Richard M. Stallman"?


> Release:       2  

https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning


> License:       GPLv3

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text


> # Archive generated from git repository
> # No modifications made
> Source0:       %{name}-%{version}.zip

https://fedoraproject.org/wiki/Packaging:SourceURL


> install -m 755 %{_builddir}/%{name}-%{version}/vrms-rpm.sh 
> %{buildroot}%{_bindir}/vrms-rpm
> install -m 644 %{_builddir}/%{name}-%{version}/vrms-rpm.man 
> %{buildroot}%{_mandir}/man1/vrms-rpm.1

Examine the rpmbuild build output and notice that at the start of every main
spec file section, such as %prep, %build, %install, %clean, rpmbuild enters the
builddir automatically. If it doesn't, adjust the %setup macro in the %prep
section appropriately. It is not necessary to specify the full source path like
you've done it here.


> %files
> %{_mandir}/man1/vrms-rpm.1.gz

The more flexible notation for manual pages is 

  %{_mandir}/man1/vrms-rpm.1*

to cover any compressor and even disabled compression.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to