https://bugzilla.redhat.com/show_bug.cgi?id=1401302
--- Comment #20 from Miro Hrončok <[email protected]> --- (In reply to Miro Hrončok from comment #19) > (In reply to Jaroslav Škarvada from comment #17) > > Few comments from me, but none is blocker: > > > BuildRequires: python3-sip > > > > This is not needed, because there is already: > > > BuildRequires: python3-sip-devel > > > > It's guaranteed by guidelines that it will bring-in the python3-sip package > > automatically. Done. > > > %if "%{_libdir}" == "/usr/lib64" > > > sed -i 's|DESTINATION lib|DESTINATION lib64|g' CMakeLists.txt > > > sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR lib64|g' > > > CMakeLists.txt > > > %endif > > > > Maybe simpler way: > > sed -i 's|DESTINATION lib|DESTINATION %{_lib}|g' CMakeLists.txt > > sed -i 's|PYTHON_SITE_PACKAGES_DIR lib|PYTHON_SITE_PACKAGES_DIR %{_lib}|g' Done. > > Is the patch needed? Couldn't be the same behavior achieved by e.g.: > > cmake -DCMAKE_SKIP_RPATH:BOOL=ON > Will try. Works. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
