https://bugzilla.redhat.com/show_bug.cgi?id=1438913
--- Comment #2 from Miro Hrončok <mhron...@redhat.com> --- (In reply to Sanqui (David Labský) from comment #1) > In the package description: > >Unevaluated notebooks i.e. notebooks without stored output cells will be > >automatically executed during the Sphinx build process. > > Personally, I would put commas in this sentence like so: > > >Unevaluated notebooks, i.e. notebooks without stored output cells, will be > >automatically executed during the Sphinx build process. OK. > The description also seems to differ between the linked spec file and the one > in the SRPM, see below. I've updated a typo and forgot to reupload the SRPM or spec. Will fix with the above change. > LICENSE can be found in the source directory. > [?]: License file installed when any subpackage combination is installed. > Not sure how to test yet This has just one built package (python3-nbsphinx) - it contains %license LICENSE, so it should be fine. If there are more built packages that does not depen on each other, such as python2-foo and python3-foo, they all need %license LICENSE. However if the pakcages depend on each other (for example bar and bar-devel depending on the first), it is ok to put %license LICENSE only to bar. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
