https://bugzilla.redhat.com/show_bug.cgi?id=1439808
--- Comment #2 from Vít Ondruch <vondr...@redhat.com> --- (In reply to Dominic Cleal from comment #1) Thanks for picking up this review. > Issues: > ======= > - The "License" field of both the main package and -doc package should be > AND, > not OR (it's a combination of licences, not dual-licensed) Apparently I messed this up. Should be fixed now. > - Missing license text for MPL 2.0 I asked upstream about this, but it should not be showstopper. https://github.com/weppos/publicsuffix-ruby/issues/137 > - Small discrepancy between spec file and the SRPM (missing comment in -doc > about licensing), ensure the SRPM one with the comment is used If I am not mistaken, the .spec link was aligned with the SRPM, however you are right that the latest .spec revision contains the licensing remark: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-public_suffix.git/commit/?id=653d4de6607d0c46d1d04881e9dac5fc71b64f05 I did not bothered to update the SRPM (because then I would need to submit new Koji build etc ...) Here is the update version: Spec: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-public_suffix.git/plain/rubygem-public_suffix.spec?id=e70367e1d7582b47ef1c77f1c6fa237a8f49151a SRPM: http://people.redhat.com/vondruch/rubygem-public_suffix-2.0.5-2.fc27.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=18834334 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
