https://bugzilla.redhat.com/show_bug.cgi?id=1440406

Jens Lody <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
       Docs Contact|                            |[email protected]
              Flags|                            |fedora-review?



--- Comment #3 from Jens Lody <[email protected]> ---
Looks good so far.
There are two or three questions:

Shouldn't the versioned Requires only have a single equal-sign ?

What about the dbus-files ?
The service-file should be under /usr/, but no other package installs the
*.conf-file there, they all keep (or install) it under /etc. I did not find
anything in the guidelines about that.

Shouldn't the service be enabled as default ?
And therefore get a preset-file ?
I think it might be expected by the normal user to work out of the box with
default settings.
It should be covered by
https://fedoraproject.org/wiki/Packaging:DefaultServices#Locally_running_services
.

Jens

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to