https://bugzilla.redhat.com/show_bug.cgi?id=1431761



--- Comment #3 from Athos Ribeiro <[email protected]> ---
Hello Fabio,

I am taking this review :)

- The conditional block on line 130 seems to be duplicated.

- There is no 1.1.0 version for this package. Latest git tag is 1.0.0.

- Note that the X.Y format for the release tag is suggested for pre-releases,
not post-releases. Also, the versioning guidelines were changed last month [1].
In particular, it seems that including the date the snapshot was taken is a
must item (in this case, we should also update gofed).

Other than that, the package looks good.

[1] https://fedoraproject.org/wiki/Packaging:Versioning

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to