https://bugzilla.redhat.com/show_bug.cgi?id=1332267



--- Comment #3 from Athos Ribeiro <[email protected]> ---
Hello Luis,

I am taking this review.

- Although you seem to be the upstream for this package, I found nothing on the
repository showing that the packaged revision is version 1.0 (upstream is not
versioned) nor that the next version is 1.0 (if this is a pre-release package).

- Following my first observation, the Release: tag should follow the new
guidelines, where the date the snapshot was taken must appear in the tag. See
[1] and [2] for reference.

- The conditional blocks in lines 52 and 68 are empty and may be removed

- aarch64 is now part of the Exclusive arches for golang packages. It would be
nice to include it or re-generate the spec file with gofed

[1] https://fedoraproject.org/wiki/Packaging:Versioning
[2] https://fedoraproject.org/wiki/Package_Versioning_Examples

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to