https://bugzilla.redhat.com/show_bug.cgi?id=1297524

Athos Ribeiro <athoscribe...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |athoscribe...@gmail.com
           Assignee|nob...@fedoraproject.org    |athoscribe...@gmail.com
              Flags|                            |fedora-review?



--- Comment #4 from Athos Ribeiro <athoscribe...@gmail.com> ---
Hello,

I will take this review.

- License field is wrong (!!FILL!!) in the new spec.

- Version 6 is out, do you want to package it before we proceed (and use the
new gofed version to generate the spec file)?

- Note that if you are packaging a post release, you should not use the 0.N
notation. Also, there are new guidelines on pre/post releases. In special, the
date when the snapshot was taken must be in the release tag. See [1] and [2].

- You could also remove the empty conditional blocks to improve readability

[1] https://fedoraproject.org/wiki/Packaging:Versioning
[2] https://fedoraproject.org/wiki/Package_Versioning_Examples

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to