https://bugzilla.redhat.com/show_bug.cgi?id=1445887



--- Comment #3 from Petr Ĺ abata <[email protected]> ---
* Any reason to define an additional macro, %srcname, instead of simply
  using %name, which happens to be identical in this case?

* These roles execute quite a lot of stuff which the package doesn't require.
  How do you guarantee the required binaries will be present on the system?
  Is there a standard Ansible set you can rely on?

* Consider using install instead of mkdir and cp.

* Missing build dependency: coreutils

* Perhaps you could install to the new location and provide symlinks in /etc,
  although that somehow doesn't feel right.  It would make your package
  compatible with both the new and old ansible, however.  What do you think?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to