https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #21 from Vít Ondruch <vondr...@redhat.com> ---
* AppData should be validated
- Please add validation of AppData [1].
* Unneeded build dependencies
- It appears that the following BRs are not needed (at least on Rawhide):
~~~
BuildRequires: gnome-python2-rsvg
BuildRequires: intltool
BuildRequires: librsvg2-tools
BuildRequires: notification-daemon
BuildRequires: pkgconfig(libarchive)
BuildRequires: pkgconfig(dbusmenu-gtk-0.4)
BuildRequires: pkgconfig(gee-1.0)
BuildRequires: pkgconfig(librsvg-2.0)
BuildRequires: pkgconfig(libnm-glib)
BuildRequires: pkgconfig(unique-1.0)
BuildRequires: pkgconfig(dbus-glib-1)
BuildRequires: xorg-x11-utils
BuildRequires: xorg-x11-server-Xvfb
~~~
* The sqlite dependency should not be conditional
- The sqlite dependency is needed everywhere [2]. There is not any reason for
that conditional around.
* The gcc build dependency is missing
- There should be BR: gcc [3].
* Test suite.
- Is there test suite? Is it possible to execute it?
* Redundant runtime requies.
- What is the reason for "R: control-center-filesystem"
- What is the reason for "R: tsocks"
* Hardcode diorite dependency
- Since diorite does not provide any API/ABI stability ensurance, I think
that nuvolaplayer should hardcode the diorite dependency, e.g.:
Requires: diorite >= 0.3.4
- This should prevent issues such as:
~~~
$ rpm -q diorite
diorite-0.3.3-3.fc27.x86_64
$ nuvola
Master: [WARNING Δ009161us GLib-GObject] value "((GApplicationFlags)
G_APPLICATION_SEND_ENVIRONMENT | G_APPLICATION_NON_UNIQUE |
G_APPLICATION_CAN_OVERRIDE_APP_ID | 17827712)" of type 'GApplicationFlags' is
invalid or out of range for property 'flags' of type 'GApplicationFlags'
nuvola: symbol lookup error: /lib64/libnuvolaplayer3-runner.so: undefined
symbol: diorite_actions_add_actions
~~~
* Vala files => -devel subpackage
- I am not expert in Vala, but are the %{_datadir}/vala/vapi/* files needed
for runtime? I'd be surprised if they are. Don't they belong to -devel
subpackage?
* Bundled engine.io library?
- It seems engine.io library is bundled by nuvolaplayer. Is it required for
something? If yes, shouldn't it be extracted or at least there should be
the "bundled()" provider [4].
* What is the purpose of %{_datadir}/nuvolaplayer3/web_apps/test
- Is the content of the directory used somewhere?
* What is the purpose of %{_datadir}/nuvolaplayer3/audio
- Is the .mp3 fie used somewhere for something?
* Directory ownership
- Please check the directory ownership. It seems that the package quite often
owns just files, but not the directories.
* License
- Could you please check the licensing? Nuvolaplayer is BSD, but the
engine.io is MIT.
[1] https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage
[2] https://github.com/tiliado/nuvolaplayer/blob/master/wscript#L248
[3]
https://fedoraproject.org/wiki/Packaging:C_and_C++#BuildRequires_and_Requires
[4]
https://github.com/tiliado/nuvolaplayer/commit/56171f4d021d65adebf1ae234ba3218a2ba9ad11
[5] https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
