https://bugzilla.redhat.com/show_bug.cgi?id=1448298

František Dvořák <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from František Dvořák <[email protected]> ---
Nice packaging.

* I guess the Rakefile modification is not strictly needed, but it is there as
prevention, because pkgconfig is not used?

* Not using BR pkgconfig(webkit2gtk-4.0) is good idea, development dependency
of webkitgtk4 is not needed here.

* run-test.rb probably doesn't need to load modules (only the code at the end
is needed). But it is actually good to perform only minimal changes as used
here.

* Usage of Obsoletes is well commented.


Package APPROVED!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to