https://bugzilla.redhat.com/show_bug.cgi?id=1451124



--- Comment #4 from Jan Chaloupka <jchal...@redhat.com> ---
> # Obsoletes: kubernetes-cni

There is no kubernetes-cni in Fedora so far so no need to obsolete one

> # I think this is brittle vs. the build tooling as it will 

Other option is to patch ./build to use gcc-go in case some architectures
requires it. I agree that every time the package is updated the list needs to
be updated as well. Another option is to copy:
```sh
PLUGINS="plugins/meta/* plugins/main/* plugins/ipam/* plugins/test/*"
for d in $PLUGINS; do
    if [ -d $d ]; then
        plugin=$(basename $d)
        echo "  " $plugin
        %gobuild -o bin/$plugin %{import_path}/$d
    fi
done
```
and replace all the %gobuild -o bin/plugins/ like lines.

> # why can't you go test ./...

Very often some of the tests fail due to incomplete environment configuration.
Given the list the failing tests can be commented out to run at least
something. At the same time the failing tests can be commented with a reason
why they are failing. Once a CI take care of the tests, the %check section will
disappear.

> Name: containernetworking

Given the project import path prefix is github.com/containernetworking/cni, I
would stick with containernetworking-cni name in case other projects will
appear under github.com/containernetworking. In future, they may be
github.com/somecompany/containernetworking project which would collide with the
name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to