https://bugzilla.redhat.com/show_bug.cgi?id=1422683
--- Comment #8 from Tom Hughes <t...@compton.nu> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file astribank_license.c is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/package/dahdi-tools See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "GPL (v2 or later)", "*No copyright* GPL (v2)", "Unknown or generated", "*No copyright* GPL", "MIT/X11 (BSD like)", "*No copyright* CC0 (v8)", "Perl", "*No copyright* LGPL (v2.1)", "LGPL (v2.1)", "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2) (with incorrect FSF address)", "GPL (v2)". 213 files have unknown license. Detailed output of licensecheck in /home/tom/1422683-dahdi- tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev, /usr/lib/udev/rules.d [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [!]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dahdi- tools-libs , dahdi-tools-devel , dahdi-tools-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dahdi-tools-2.11.1-2.fc27.x86_64.rpm dahdi-tools-libs-2.11.1-2.fc27.x86_64.rpm dahdi-tools-devel-2.11.1-2.fc27.x86_64.rpm dahdi-tools-debuginfo-2.11.1-2.fc27.x86_64.rpm dahdi-tools-2.11.1-2.fc27.src.rpm dahdi-tools.x86_64: W: spelling-error Summary(en_US) Userspace -> User space, User-space, Users pace dahdi-tools.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace dahdi-tools.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools.x86_64: W: no-manual-page-for-binary dahdi_speed dahdi-tools-libs.x86_64: W: no-documentation dahdi-tools-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools-devel.x86_64: W: only-non-binary-in-usr-lib dahdi-tools-devel.x86_64: W: no-documentation dahdi-tools.src: W: spelling-error Summary(en_US) Userspace -> User space, User-space, Users pace dahdi-tools.src: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace 5 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (debuginfo) ------------------- Checking: dahdi-tools-debuginfo-2.11.1-2.fc27.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory dahdi-tools.x86_64: W: spelling-error Summary(en_US) Userspace -> User space, User-space, Users pace dahdi-tools.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace dahdi-tools.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools.x86_64: W: no-manual-page-for-binary dahdi_speed dahdi-tools-devel.x86_64: W: only-non-binary-in-usr-lib dahdi-tools-devel.x86_64: W: no-documentation dahdi-tools-libs.x86_64: W: no-documentation dahdi-tools-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id dahdi-tools-libs.x86_64: W: hidden-file-or-dir /usr/lib/.build-id 4 packages and 0 specfiles checked; 0 errors, 10 warnings. Requires -------- dahdi-tools (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/perl /usr/sbin/groupadd /usr/sbin/useradd config(dahdi-tools) dahdi-tools-libs(x86-64) libc.so.6()(64bit) libm.so.6()(64bit) libnewt.so.0.52()(64bit) libnewt.so.0.52(NEWT_0.52)(64bit) libpthread.so.0()(64bit) libtonezone.so.2()(64bit) libusb-1.0.so.0()(64bit) perl(:MODULE_COMPAT_5.24.1) rtld(GNU_HASH) systemd dahdi-tools-devel (rpmlib, GLIBC filtered): dahdi-tools-libs(x86-64) libtonezone.so.2()(64bit) dahdi-tools-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) dahdi-tools-debuginfo (rpmlib, GLIBC filtered): Provides -------- dahdi-tools: config(dahdi-tools) dahdi-tools dahdi-tools(x86-64) dahdi-tools-devel: dahdi-tools-devel dahdi-tools-devel(x86-64) dahdi-tools-libs: dahdi-tools-libs dahdi-tools-libs(x86-64) libtonezone.so.2()(64bit) dahdi-tools-debuginfo: dahdi-tools-debuginfo dahdi-tools-debuginfo(x86-64) Source checksums ---------------- http://downloads.asterisk.org/pub/telephony/dahdi-linux/releases/dahdi-linux-2.11.1.tar.gz : CHECKSUM(SHA256) this package : f59f382365118205e77d2874f1c0e1546e936247bcc45f07a43bc21778bee9df CHECKSUM(SHA256) upstream package : f59f382365118205e77d2874f1c0e1546e936247bcc45f07a43bc21778bee9df http://downloads.asterisk.org/pub/telephony/dahdi-linux/releases/dahdi-linux-2.11.1.tar.gz.asc : CHECKSUM(SHA256) this package : 0022ac09e9cba17b5ac9421292824c0384dcb70539272da2415f6abf664d1f1a CHECKSUM(SHA256) upstream package : 0022ac09e9cba17b5ac9421292824c0384dcb70539272da2415f6abf664d1f1a http://downloads.asterisk.org/pub/telephony/dahdi-tools/releases/dahdi-tools-2.11.1.tar.gz : CHECKSUM(SHA256) this package : 53ffeb333f3e44b0c88e5b17475cdbf87d3f652eb81a6422de76250c061e2909 CHECKSUM(SHA256) upstream package : 53ffeb333f3e44b0c88e5b17475cdbf87d3f652eb81a6422de76250c061e2909 http://downloads.asterisk.org/pub/telephony/dahdi-tools/releases/dahdi-tools-2.11.1.tar.gz.asc : CHECKSUM(SHA256) this package : 1f194e68c460c80c8e6fe4525749e2f45e93771a87d8d8955a4e73a8ed903e99 CHECKSUM(SHA256) upstream package : 1f194e68c460c80c8e6fe4525749e2f45e93771a87d8d8955a4e73a8ed903e99 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1422683 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++, Perl Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
