https://bugzilla.redhat.com/show_bug.cgi?id=1418396
Björn "besser82" Esser <besse...@fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |besse...@fedoraproject.org
Assignee|ignate...@redhat.com |besse...@fedoraproject.org
Flags| |fedora-review?
--- Comment #9 from Björn "besser82" Esser <besse...@fedoraproject.org> ---
I'll take it for review…
From having a quick look over the spec file:
* Group tag is obsolete since el6. I'd suggest removal.
* It's better to use %make_build instead of make %{?_smp_mflags}.
* %autosetup -p1 -n %{name}-%{version}: You can omit ' -n
%{name}-%{version}'.
* %{python2_sitelib}/*: Simply globbing the whole contents of this subdir
usualy isn't a good idea… It's better to explicitly name the single dirs
or files being dropped there; this is especially important when converting
a package to python3 later.
I'll run f-r in the meantime.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
