https://bugzilla.redhat.com/show_bug.cgi?id=1457929
--- Comment #18 from René Cannaò <rene.can...@gmail.com> --- (In reply to Augusto Caringi from comment #15) > (In reply to Pavel Raiskup from comment #12) > > Per '/usr/share/doc/jemalloc/jemalloc.html': > > > > opt.xmalloc (bool) r- [--enable-xmalloc] > > > > Abort-on-out-of-memory enabled/disabled. If enabled, rather than > > returning failure for any allocation function, display a diagnostic > > message on STDERR_FILENO and cause the program to drop core (using > > abort(3)). If an application is designed to depend on this behavior, > > set the option at compile time by including the following in the > > source code: > > > > malloc_conf = "xmalloc:true"; > > > > This option is disabled by default. > > > > I'm not sure. Does that mean that we could build the support for > > (--enable-xmalloc) into default Fedora package, without actually changing > > the default behavior? If yes, bug against jemalloc should be filled and > > for the time being we could bundle ... > > As far as I understand... Yes. I'll file a bug asking for that. I am not sure if Fedora should have jemalloc with xmalloc support, as upstream intentionally has this option disabled by default. ProxySQL 1.4.x doesn't just enable xmalloc , but also applies a patch for it because by default xmalloc can hurt performance. See: * https://github.com/jemalloc/jemalloc/issues/522 * https://github.com/sysown/proxysql/issues/823 * https://github.com/sysown/proxysql/commit/42a55f750c362299c9f0ed7834cdedc5f9778f47 I asked to apply to patch upstream, but was rejected with a valid reason: https://github.com/jemalloc/jemalloc/pull/523 https://github.com/jemalloc/jemalloc/issues/522 Nonetheless the patch lives in ProxySQL. > > > > re2 > > > - patched (from proxysql_notes.txt: Because ProxySQL will process > > > regular expression in an already thread-safe environment, re2 is > > > patches to remove locking) > > > > Interesting. Does the locking hurt performance? > > Good question, I didn't measure, but probably yes. > > > > - Another reason: proxysql includes a private header file which is not > > > present in re2-devel Fedora package (regexp.h): > > > // --- SPONSORED LINK > > > -------------------------------------------------- > > > // If you want to use this library for regular expression matching, > > > // you should use re2/re2.h, which provides a class RE2 that > > > // mimics the PCRE interface provided by PCRE's C++ wrappers. > > > // This header describes the low-level interface used to implement RE2 > > > // and may change in backwards-incompatible ways from time to time. > > > // In contrast, RE2's interface will not. > > > // > > > --------------------------------------------------------------------- > > > > I think it is fair to bundle too .. to not prolong the review too much, but > > we > > should have new bug for this issue. It seems to me that the ./configure > > script should have additional option "disabling" the "patched" version of > > re2. > > Right, but the project uses just Makefiles (no Autotools). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
