https://bugzilla.redhat.com/show_bug.cgi?id=1441803
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org |zbys...@in.waw.pl
Flags| |fedora-review+
--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
%description should be wrapped to <80 columns.
Url, Source0: http → https.
Rpmlint
-------
Checking: kproperty-3.0.1-1.fc27.x86_64.rpm
kproperty-devel-3.0.1-1.fc27.x86_64.rpm
kproperty-debuginfo-3.0.1-1.fc27.x86_64.rpm
kproperty-3.0.1-1.fc27.src.rpm
kproperty.x86_64: E: description-line-too-long C A property editing framework
with editor widget similar to what is
known from Qt Designer.
kproperty.src: E: description-line-too-long C A property editing framework with
editor widget similar to what is known from Qt Designer.
Right.
kproperty.x86_64: W: no-documentation
kproperty.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
kproperty.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
kproperty-devel.x86_64: W: only-non-binary-in-usr-lib
kproperty-devel.x86_64: W: no-documentation
The rest is OK.
kproperty.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libKPropertyCore3.so.3.0 /lib64/libm.so.6
kproperty.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libKPropertyCore3.so.3.0 /lib64/libgcc_s.so.1
kproperty.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libKF5ConfigGui.so.5
kproperty.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libQt5Xml.so.5
kproperty.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libm.so.6
kproperty.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libgcc_s.so.1
Hm, those might be worth cleaning up. At least libKF5ConfigGui, libQt5Xml.
+ package name is OK
+ licence is acceptable for Fedora (LGPLv2+)
+ license is specified correctly
+ builds and installs OK
+ P/R/BR look correct
(some Requires might be trimmed possibly)
+ scriptlets follow the guidelines
+ fedora-review finds no issues
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
