https://bugzilla.redhat.com/show_bug.cgi?id=1462983



--- Comment #3 from Filip SzymaƄski <[email protected]> ---
(In reply to Yatin Karel from comment #2)

> 1) - %files contains *, should be good if * is replaced with module_name
`*` captures both the module directory and the egg-info directory, see:
https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Egg_Metadata_Using_Setuptools

> 2) - use python2-%{pypi_name} instead of python[23]-phonenumbers for
> consistency
Yes

> 3) use {} arond variables like __python --> %{__python} for consistency
Yes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to