https://bugzilla.redhat.com/show_bug.cgi?id=1452958

Terje Røsten <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Terje Røsten <[email protected]> ---
Some quick comments:

 - remove BuildRoot line, it set by rpmbuild
 - use one package per line in buildreq, req (and sort them)
 - remove
%clean
rm -rf %{buildroot}
 - remove %defattr(-,root,root,-) line
 - is

Provides:       python3-%{name} = %{version}

   needed when doing:

%{?python_provide:%python_provide python-sasutils}

  - I prefer to list bin files first in %files
  - can you provide a rawhide scratch build in koji?

Upstream (outside fedora review):
  - add man pages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to