https://bugzilla.redhat.com/show_bug.cgi?id=1468949
--- Comment #7 from Michel Alexandre Salim <[email protected]> --- Spec URL: https://salimma.fedorapeople.org/specs/python/python3-greenlet.spec SRPM URL: https://salimma.fedorapeople.org/specs/python/python3-greenlet-0.4.12-1.el7.centos.src.rpm Fixed all the review comments -- once this is in I'll backport the changes to the main python-greenlet package too. (In reply to Dominik 'Rathann' Mierzejewski from comment #5) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - License: field is incorrect, should be "MIT and Python". Fixed > - Missing > Requires: python%{python3_pkgversion}-libs > for /usr/include/python3.4m ownership in the > python34-greenlet-devel subpackage. Fixed -- note: this dependency is actually transitively satisfied through the base package, but it might be better to be explicit > - Missing > Requires: python%{python3_pkgversion}-%{modname}%{?_isa} = > %{version}-%{release} > in the python34-greenlet-devel subpackage. Fixed > - You should make use of python3_version and python3_version_nodots > instead of using wildcards in %files sections. > Fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
