https://bugzilla.redhat.com/show_bug.cgi?id=1268360



--- Comment #16 from Pavel Valena <[email protected]> ---
(In reply to Ilya Gradina from comment #14)
> Thx, for review.
> 
> I have a few questions.
> 
> 1. "Use Fedora 27 dist tag to create srpm"
>   - Why can not I use 26?

Fedora 27 is current rawhide version. Previously 26 was correct, but now it's
currently release so it's eligible for updates only AFAIK.

> 
> 2. "Add `ruby` BuildRequire to ensure MRI is used for tests."
>   - What did you mean? "BuildRequires: ruby(release)" - already available.

This could in some case pull 'jruby' instead of 'ruby' dependency, as both
satisfy this require.

```
$ dnf repoquery -q --disablerepo='*' --qf "%{name}" --enablerepo='rawhide'
--whatprovides 'ruby(release)'
jruby
ruby-libs
```

> 
> 3. "Move all `%exclude` macros to main package"
>   - you meant all `%exclude` macros move to section %files

Yes, that's correct. %files section without arg creates main package and
'%files doc' creates the doc subpackage for this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to