https://bugzilla.redhat.com/show_bug.cgi?id=1462465

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbys...@in.waw.pl
           Assignee|nob...@fedoraproject.org    |zbys...@in.waw.pl
              Flags|                            |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
> Suggests:            console-setup
Doesn't this duplicate functionality provided by kbd and
systemd-vconsole-setup? Are you sure it's still useful?

> Suggests:            aterm
> Suggests:            xterm
Both of those are very old, and work badly on hidpi screens. Are they better
than the default terminal emulators?

Braces around the %post and %postun scriptlets are unneeded.

+ package name is OK
+ license is acceptable (GPLv2+)
+ license is specified correctly
+ builds and installs and runs OK
+ scriptlets are sane
+ provides/requires/buildrequires look OK

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to